COVID-19-electronic-health-system / Corona-tracker

An easy-to-use PWA to monitor the user's wellness and learn about COVID-19.
https://coronatracker.me/
MIT License
234 stars 101 forks source link

[FEAT] Default translationValue to english value if empty #729

Open ngiangre opened 4 years ago

ngiangre commented 4 years ago

⚠️ IMPORTANT: Please fill out this template to give us as much information as possible to consider/implement the feature.

Prerequisites

Summary

If the translation of text hasn't be added by a translator, the resulting value will be empty. In this case, the value should instead be the english value so that the key can be used by i18next while indicating there needs to be a translation of the text.

Motivation

When the app is in a non-english locale, there needs to be a translation provided and if not, a way to signal the translation needs to be added. This signal can be the text in english.

Possible Alternatives

Nothing shows up so debugging is more difficult.

Additional Context

pull_gsheets_translations_mvp.py needs to be updated with a conditional. If the translatedValue is empty, replace with the english value.

pavel-ilin commented 4 years ago

I can work on this.