search

COVID-19-electronic-health-system / Corona-tracker

An easy-to-use PWA to monitor the user's wellness and learn about COVID-19.
https://coronatracker.me/
MIT License
235 stars 101 forks source link

Use connect.js lib instead of blockstack.js #93

Closed friedger closed 4 years ago

friedger commented 4 years ago

connect.js library simplifies the on-boarding a lot.

SomeMoosery commented 4 years ago

Are you saying we don't utilize blockstack? At this point, at least for an MVP, we've kind of set up a good amount of scaffolding for it so to get it out the door I'm thinking we should stick with Blockstack, but if I'm missing context feel free to fill me in.

The choice to go with Blockstack was to have both a serverless backend and to protect data privacy (we, nor AWS/Azure/GCP have the ability to make use of any of the users' data). I do agree, though, that maybe in the longterm we look for an alternative or complementary way for users to log in since Blockstack is not very ubiquitous.

Can you link the package as well? The only thing I found titled connect-js was a deprecated Facebook package. There was connect as well, but I don't know if this is what you were referring to.

tesla809 commented 4 years ago

Yea, some more description around the PR is needed @friedger

This is a major change to the design, so some description of benefits is needed.

The MVP is predicated on using Blockstack, at least for now. We can add additional sign-in methods, but to avoid any HIPPIA issues, we choose Blockstack to decentralize the data so the user controls it. Any data that is centralized is encrypted by default with Radiks.

friedger commented 4 years ago

The repo for connect is https://github.com/blockstack/ux/tree/master/packages/connect It is improved UI for Blockstack

SomeMoosery commented 4 years ago

Oh, nice, I hadn't seen this before. I'll do some looking into it but I feel like it could definitely be worth integrating!

friedger commented 4 years ago

These are the changes to use connect.js : https://github.com/friedger/Corona-tracker/commit/8f230249b4eddd6e351ae060fee7530133b69d3d

I am happy to prepare a pull request

SomeMoosery commented 4 years ago

PR would be great! Said the same on your comment as well 👍