Closed u5surf closed 4 years ago
So right now we're doing this check in the frontend as far as I know - do we think it could be worthwhile to add in the backend as well as a failsafe? Or does that seem redundant?
I like the idea of it in both places, but now I'm thinking it might be inconvenient if we want to change the regex/validation since we'll have to do it in both places.
So do you think we should close this for now and reopen if the need arises?
⚠️ IMPORTANT: Please do not create a Pull Request without creating an issue first.
All changes need to be discusssed before proceeding. Failure to do so may result in the pull request being rejected.
Please be sure to review our Code of Conduct, Contributing Guidelines, and Support documentation before submitting a pull request.
Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.
Fixes #5
Summary
I added validation phone number when we subscription the service.
Test Plan (required)
build lamdas/subscrition/main.go and lamdas/subscrition/main.go and then, to indicate validation, we'll be executing these to subscribe valid or invalid number case.
Final Checklist
package.json
?1.0.9
=>1.0.10
yarn
notnpm
? (important!)yarn lint
on the code?