If model is a SIR type then it is missing .units (this function expects .units). Is it NetworkedSIR or other specialization (I don't see inheritance though)? If it is then t = has issues because model.Rt doesn't exist. I guess t= can be moved inside the loop?
Also in the for loop in this function, model is reused that may case mypy typer checker to fail (not essential).
Similarly plot_curves probably expects models: Sequence[NetworkedSIR] rather than model: Sequence[SIR]?
https://github.com/COVID-IWG/epimargin/blob/7170f5f25a7c39f6b67c061f1a807ecb378b81b4/epimargin/plots.py#L304
If
model
is aSIR
type then it is missing.units
(this function expects.units
). Is itNetworkedSIR
or other specialization (I don't see inheritance though)? If it is thent =
has issues becausemodel.Rt
doesn't exist. I guesst=
can be moved inside the loop? Also in the for loop in this function,model
is reused that may casemypy
typer checker to fail (not essential).Similarly
plot_curves
probably expectsmodels: Sequence[NetworkedSIR]
rather thanmodel: Sequence[SIR]
?https://github.com/openjournals/joss-reviews/issues/3464