COVID-IWG / epimargin

networked, stochastic SIRD epidemiological model with Bayesian parameter estimation and policy scenario comparison tools
https://www.adaptivecontrol.org/
MIT License
9 stars 5 forks source link

model : SIR has missing `units` #124

Open dilawar opened 3 years ago

dilawar commented 3 years ago

https://github.com/COVID-IWG/epimargin/blob/7170f5f25a7c39f6b67c061f1a807ecb378b81b4/epimargin/plots.py#L304

If model is a SIR type then it is missing .units (this function expects .units). Is it NetworkedSIR or other specialization (I don't see inheritance though)? If it is then t = has issues because model.Rt doesn't exist. I guess t= can be moved inside the loop? Also in the for loop in this function, model is reused that may case mypy typer checker to fail (not essential).

Similarly plot_curves probably expects models: Sequence[NetworkedSIR] rather than model: Sequence[SIR]?

https://github.com/openjournals/joss-reviews/issues/3464