Type checking in models.py - Githubissues

COVID-IWG / epimargin

networked, stochastic SIRD epidemiological model with Bayesian parameter estimation and policy scenario comparison tools

https://www.adaptivecontrol.org/

MIT License

9 stars 5 forks source link

Type checking in models.py #126

Open dilawar opened 3 years ago

dilawar commented 3 years ago

[ ] np.array members are called on int

https://github.com/COVID-IWG/epimargin/blob/7170f5f25a7c39f6b67c061f1a807ecb378b81b4/epimargin/models.py#L151

S, I and D are int here: clip wont work. Are these self.S etc that are list[int]?

Similary .copy(), .astype(), .clip() is called on int in a few places.

[ ] int is being treated as Sequence

https://github.com/COVID-IWG/epimargin/blob/7170f5f25a7c39f6b67c061f1a807ecb378b81b4/epimargin/models.py#L250

doesn't make sense since S0 is int in argument.