COVID19-PIRAT / backend

GNU General Public License v3.0
2 stars 1 forks source link

Remove postalcode field of resources #127

Closed chaoran-chen closed 4 years ago

chaoran-chen commented 4 years ago

It is enough that an offer has one address. For the resources, there is no need to enter another postal code again. Therefore, the postal code field of the three resources should be completely removed.

MaxWies commented 4 years ago

So resources in the offer share all the same postalcode which is given within the provider object?

chaoran-chen commented 4 years ago

Yes.

MaxWies commented 4 years ago

But the provider might have resources located at another location? For me this makes our service more limited. Do you have some reasons for this?

chaoran-chen commented 4 years ago

Well, we expect that the provider will be in close proximity to the resource. And as we have seen in the case of the registered helpers, in most cases, the helpers enter their information themselves.

The main reason for changing it is that we are going to have major changes to the address systems. The required information to identify a location should be configurable for each region. It might be the case that some regions don't have postal code at all. It would make things a lot simpler if there are not so many places where we have an address.

MaxWies commented 4 years ago

Alright. This also affects our database. device, consumableand personal won't have a corresponding address anymore, am I right?

chaoran-chen commented 4 years ago

Correct