chore: remove unnecessary null check

COVID19Tracking / website

The COVID Tracking Project website

https://covidtracking.com/

Apache License 2.0

498 stars 189 forks source link

chore: remove unnecessary null check #1888

Closed Trott closed 2 years ago

Trott commented 2 years ago

The typeof check to confirm that dataPointValue is a number immediately precedes a check that dataPointValue is not null. However all number values, including the unusual ones like NaN and Infinity (and 0), will pass that check. All number values will be != null. This change removes the check.

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging fa9360387694dc4d073ebb169006fc1e462e6285 into bdee11f90f18cedc1732e10927a5ff585bffec85 - view on LGTM.com

fixed alerts:

1 for Comparison between inconvertible types

netlify[bot] commented 2 years ago

✔️ This is a preview version of the site. Built without sensitive environment variables

🔨 Explore the source changes: fa9360387694dc4d073ebb169006fc1e462e6285

🔍 Inspect the deploy log: https://app.netlify.com/sites/upbeat-lovelace-3e9fff/deploys/61df1eb67db03600070883f4

😎 Browse the preview: https://deploy-preview-1888--upbeat-lovelace-3e9fff.netlify.app