search

COVID19Tracking / website

The COVID Tracking Project website
https://covidtracking.com/
Apache License 2.0
498 stars 189 forks source link

failing tests due to hardcoded year in expected results #1889

Closed Trott closed 2 years ago

Trott commented 2 years ago

Tests are failing because the year is hardcoded into the expected results.

This seems to be a jest thing and I don't know if it's supposed to get automatically updated or if there's a way to make that particular part of the results more forgiving so that you don't have to update it every year, or what, but taking a moment to log the issue. Thanks.

Trott commented 2 years ago

This seems to be a jest thing

Ref: https://jestjs.io/docs/snapshot-testing

kevee commented 2 years ago

Thanks, @Trott for the catch. The issue is that a Jest snapshot that should have been updated daily wasn't being run because of the shutdown of some of our Github actions. I've manually bumped the snapshots in #1894. This issue will be closed when the PR is merged.