search

COWestSlopeTech / project-kronos

MIT License
0 stars 1 forks source link

Add linter to CI #44

Closed tstirrat15 closed 4 years ago

tstirrat15 commented 4 years ago

Fixes #28

Motivation

This'll do a lot to keep style consistent, and flake8 will also catch a whole lot of stupid mistakes.

Changes

See commit messages. Note that I removed a bunch of boilerplate code that hasn't been used yet - I'm personally okay with this on YAGNI, but we can also address this using # noqa comments.

Testing

Run flake8 on your local and see that it comes back clean. Review tox.ini and see the exceptions that I've made to the standard configuration.

justinlewis commented 4 years ago

@tstirrat15 did you see my comment about adding MyPy to check typing on build? We could move that to a different ticket if that makes more sense.

tstirrat15 commented 4 years ago

See #43. I forgot to link it in #28 :P