Add `GA_property_id` and replace `_GA_TID` CL input with it - Githubissues

COXIT-CO / ga_zoho_integration

Python script which integrates Zoho CRM deals data with google analytics.

0 stars 0 forks source link

Add `GA_property_id` and replace `_GA_TID` CL input with it #27

Closed BearVictor closed 3 years ago

BearVictor commented 3 years ago

What does it do?

add ga_property_id as a field in zoho stage, and we take this from request.

What else do you need to know?

remove tid from console ADD verification ga_client id and ga_propery_id . Now if this field is empty, in log file write WARNING.

Checklist

[x] Pipeline set to Ready To Deploy or Review/QA
[x] Pull request is prepared: Added to sprint, added yourself as assignee, Zenhub task is linked, reviewers are added
[x] PR is not very big (about 200 lines of change)
[x] Doesn't create any new FIXME or TODO comments. If not, please explain or create issues to resolve it.
[x] Doesn’t deliver half-baked changes
[x] Tested manually or with a new unit test
[x] Follows best practice rules

Demo screenshots or video/animation, if any

iramykytyn commented 3 years ago

Tested on AWS server with client account. KeyError!

Screenshot 2020-11-03 at 12 58 23