Update script with classes - Githubissues

COXIT-CO / ga_zoho_integration

Python script which integrates Zoho CRM deals data with google analytics.

0 stars 0 forks source link

Update script with classes #62

Closed Zhornovyi closed 3 years ago

Zhornovyi commented 3 years ago

What does it do?

The app has 3 classes:

AppConfig class provides storing of parser parameters and some project configurations.
ZohoApi class provides methods and fields to access to Zoho and receave response for GA.
GaApi class provides Zoho response processing and sending it to GA.

What else do you need to know?

In configs I also rewrite the method of logger initialization. Currently it uses initialization with logging lib functions.
In this PR I also have finished and tasted the #48 issue. The directory for logs can be taken from parameters. By default its ./logs
- I also replaced functions for creating refreshing threads with Timer class from threading lib.

Checklist

[x] Pipeline set to Ready To Deploy or Review/QA
[x] Pull request is prepared: Added to sprint, added yourself as assignee, Zenhub task is linked, reviewers are added
[ ] PR is not very big (about 200 lines of change)
[x] Doesn't create any new FIXME or TODO comments. If not, please explain or create issues to resolve it.
[x] Doesn’t deliver half-baked changes
[x] Tested manually or with a new unit test
[x] Follows best practice rules

Demo screenshots or video/animation, if any