CPCLAB-UNIPI / SIPPY

Systems Identification Package for PYthon
GNU Lesser General Public License v3.0
269 stars 92 forks source link

update test_armax.ipynb #18

Closed imgeorgiev closed 4 years ago

imgeorgiev commented 4 years ago

Motivation

The test_armax.ipynb was outdated in its usage of PRBS_seq which is no longer part of scipy and thus breaks the notebook. Additionally, some of the plots were difficult to read due to the lack of legends.

Changes

Testing

Tested and worked with python 3.7.5 and scipy 1.3.2

PS. The other examples don't seem to have this issue.

CPCLAB-UNIPI commented 4 years ago

Thanks for updating this notebook for the ARMAX example. Note that GBN_seq function (previously named PRBS_seq) is internal to SIPPY and not scipy.