Please update document SS_max_order or SS_orders if a valid IC is used.

CPCLAB-UNIPI / SIPPY

Systems Identification Package for PYthon

GNU Lesser General Public License v3.0

269 stars 92 forks source link

Please update document SS_max_order or SS_orders if a valid IC is used. #31

Open jamestjsp opened 3 years ago

jamestjsp commented 3 years ago

SS_max_order has no effect in any scenario, it will always search in the range from 1 to 10 (default value of SS_orders) https://github.com/CPCLAB-UNIPI/SIPPY/blob/b699ab99d4f5a0c74941e1752f460241ce4744ab/sippy/__init__.py#L736

CPCLAB-UNIPI commented 3 years ago

Dear jamestjsp, as for issue #32, can you please give an example of what you are trying to simulate? SS_max_order is not entering the case where you use IC method, but only the variable SS_orders as described in the user_guide. Do you find misleading what is written in section 5.2 of the guide?

Best regards,

SIPPY team