CPCLAB-UNIPI / SIPPY

Systems Identification Package for PYthon
GNU Lesser General Public License v3.0
269 stars 92 forks source link

NameError: name 'Nb' is not defined #36

Open Tsokneelsbd opened 2 years ago

Tsokneelsbd commented 2 years ago

While using Mode="IC" I am having error saying "NameError: name 'Nb' is not defined". I would like to request your help on solving this issue. Thank you !

CameronDevine commented 2 years ago

I expect the io_rls.py file is missing the line Nb = np.sum(nb[:]); however, I could be completely wrong about this.

RBdC commented 2 years ago

Dear Tsokneelsbd, thank you for using our SIPPY.

Your issue sounds strange.. Where the error arises? in a core code or in a example file? Then, it is systematic when running any example file? Can you share an example file so that we can investigate the issue ..

More, a general quote from the Guide: By using an Information Criterion (IC), the user does not need to the define the exact model orders, but he/she has to assign a range of orders and let the IC find the best combination. Note that, when an input-output model structure is selected, the information criteria are implemented only for SISO systems. This means that for MIMO systems, when using I/O models (ARX,ARMAX, etc.) IC mode is not available.

@CameronDevine: the io_rsl.py is actually missing the line Nb = np.sum(nb[:]), but this not seems the reason for the problem...

Best regards SIPPY Team

Tsokneelsbd commented 2 years ago

Screenshot 2021-11-27 121044

Tsokneelsbd commented 2 years ago

Screenshot 2021-11-27 121044

Tsokneelsbd commented 2 years ago

I am also getting TypeError: 'int' object is not subscriptable Screenshot 2021-11-27 1227472

CPCLAB-UNIPI commented 2 years ago

Dear @Tsokneelsbd, sorry for the big delay in this response. We just fixed a silly typo in the io_rls.py file (nb instead of Nb). This should solve your problem.

Let us know if now it is running errors free.

Best Regards,

SIPPY team