search

CPCLAB-UNIPI / SIPPY

Systems Identification Package for PYthon
GNU Lesser General Public License v3.0
269 stars 92 forks source link

Support new Pythons #37

Closed OrangeDog closed 2 years ago

OrangeDog commented 2 years ago

Supported is needed for 3.8, 3.9, 3.10, and onwards. Support for 2.7 should probably be dropped.

I don't know what testing you've done, but it may be as simple as removing the <=3.8 restriction.

CPCLAB-UNIPI commented 2 years ago

Dear OrangeDog, sorry for the big delay in the response. At the moment we tested SIPPY on python 3.8 at maximum and this limitation is used since we cannot guarantee results/errors with versions not yet tested. On the other hand, we can remove such limitation and see how the users respond to testing (augmenting a lot our efforts).

Let us know if you find this upgrade useful for your research.

Best regards,

SIPPY team

OrangeDog commented 2 years ago

Running the tests on multiple versions should be very easy, especially with a tool like nox.

Unless you have tested it and know it doesn't work, you shouldn't have a maximum python version. You can express what you've tested it with using just the classifiers.

Please at least remove the <=3.8 at the soonest convenience, so we can install this without having to fork and patch it.

OrangeDog commented 2 years ago

I notice that the published library is not actually from this repo: https://pypi.org/project/sippy-rcognita/ Aside from the different name, it's at version 0.2.1, and doesn't have this python restriction. However, it links here.

What's going on? Is there another fork that's being used for official development?

CPCLAB-UNIPI commented 2 years ago

Dear OrangeDog, as asked, we removed the maximum python version in setup.py. About repo https://pypi.org/project/sippy-rcognita/ it is not a fork maintained by us for official development but it is developed by third users since last autumn, that is why is sippy-rcognita and not simply sippy. However, it does link here since it takes this code as the source.

OrangeDog commented 2 years ago

Oh. Do you have any contact details or know where their fork is? They've made changes so they really shouldn't be linking to this repo.

CPCLAB-UNIPI commented 2 years ago

This is the repo that forked SIPPY and created https://pypi.org/project/sippy-rcognita/: https://github.com/AIDynamicAction/rcognita .

OrangeDog commented 2 years ago

You mean this one https://github.com/AIDynamicAction/SIPPY