search

CPColin / ceylon.markdown

A port of the commonmark.js Markdown parser and renderer to Ceylon
Apache License 2.0
5 stars 0 forks source link

Consider restricting visibility of utility functions #16

Open CPColin opened 6 years ago

CPColin commented 6 years ago

Some of the utility functions in the module are annotated shared so the tests can get at them, but it might not make sense for them to be visible in general. We should look into using the restricted annotation to tighten the visibility to the test module.

Note that using the annotation requires us to add an optional import of the test module, or the compiler blows up with a NullPointerException. Doing the import doesn't seem optimal and the exception certainly isn't, but we may need to work around the problem and file an issue in the main Ceylon repo.

CPColin commented 6 years ago

Filed eclipse/ceylon#7296. Putting this on the back burner for now.