search

CPJKU / madmom

Python audio and music signal processing library
https://madmom.readthedocs.io
Other
1.31k stars 200 forks source link

Rewrite FilterbankProcessor #248

Open superbock opened 7 years ago

superbock commented 7 years ago

FilterbankProcessor should hold all parameters to filter a Spectrogram (or the like). When processing data, it should create a Filterbank upon being called for the first time and cache it for consecutive calls (like a buffer).

superbock commented 7 years ago

Maybe, we should drop the combined spectrogram processors (i.e. FilteredSpectrogramProcessor, LogarithmicSpectrogramProcessor and LogarithmicFilteredSpectrogramProcessor) altogether? Not sure about the data classes though...

fdlm commented 7 years ago

This would break backwards compatibility. If we split this up, we should redefine the dropped processors as sequential processors containing pipelines reproducing the old behaviour, so they can be still used.

Regarding the data classes, I think they're still useful shortcuts.

Or, put differently, what do we gain if we drop the combined processors and the data classes?