search

CPJKU / madmom

Python audio and music signal processing library
https://madmom.readthedocs.io
Other
1.35k stars 206 forks source link

Changing processors import #534

Open lucainiaoge opened 11 months ago

lucainiaoge commented 11 months ago

Problem

ImportError: cannot import name 'MutableSequence' from 'collections' (......./conda_envs/thesis/lib/python3.11/collections/init.py)

Solution

Changing madmom/processors.py import

if sys.version_info[:2] >= (3, 8): from collections.abc import MutableMapping else: from collections import MutableMapping

aRI0U commented 10 months ago

Hi! Since this issue is quite annoying but very easy to fix, I'd be happy to submit a PR fixing it. Does it sound good to you? Thanks!

superbock commented 10 months ago

Yes, absolutely! This kind of issues are easy to fix, the problem still being the outdated CI pipeline, which should be fixed first. Since I'm always short on time, any PR addressing this is also greatly appreciated 🙏

aRI0U commented 10 months ago

Oh actually I just realized that this import issue has already been fixed in the main branch, however when you install madmom with pip it is an older version of the code. I guess the current solution to this specific issue is just to install madmom from source for now.

Not sure to have fully understood the outdated CI issue, however on my laptop branch main passes all tests (Ubuntu 22.04 + Python 3.10) just with pytest, no need to pass option --doctest-ignore-import-errors as in the CI workflow.

superbock commented 10 months ago

The problem is that we do not have a working CI pipeline on Github, something I'd like to have in place before merging stuff into main. Once this is done, we can work through the open PRs and fix stuff.