CPJKU / partitura

A python package for handling modern staff notation of music
https://partitura.readthedocs.io
Apache License 2.0
228 stars 15 forks source link

fixed issue #270 - Inconsistent Note Feature Size #281

Closed manoskary closed 1 year ago

manoskary commented 1 year ago

This PR addresses a minor bug with an if clause that was never reached.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.01 :tada:

Comparison is base (33b0168) 85.37% compared to head (abd9569) 85.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #281 +/- ## =========================================== + Coverage 85.37% 85.38% +0.01% =========================================== Files 79 79 Lines 13551 13586 +35 =========================================== + Hits 11569 11601 +32 - Misses 1982 1985 +3 ``` | [Impacted Files](https://app.codecov.io/gh/CPJKU/partitura/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CPJKU) | Coverage Δ | | |---|---|---| | [partitura/musicanalysis/performance\_features.py](https://app.codecov.io/gh/CPJKU/partitura/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CPJKU#diff-cGFydGl0dXJhL211c2ljYW5hbHlzaXMvcGVyZm9ybWFuY2VfZmVhdHVyZXMucHk=) | `83.62% <ø> (ø)` | | | [partitura/musicanalysis/note\_features.py](https://app.codecov.io/gh/CPJKU/partitura/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CPJKU#diff-cGFydGl0dXJhL211c2ljYW5hbHlzaXMvbm90ZV9mZWF0dXJlcy5weQ==) | `64.93% <50.00%> (+0.14%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/CPJKU/partitura/pull/281/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CPJKU)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.