PR for Release 1.4.0 - Githubissues

CPJKU / partitura

A python package for handling modern staff notation of music

https://partitura.readthedocs.io

Apache License 2.0

227 stars 15 forks source link

PR for Release 1.4.0 #320

Closed huispaty closed 11 months ago

huispaty commented 11 months ago

New Features

new class for performed notes
minimal unfolding for part
updated Musescore parser for version 4
load_score auto-selects parser based on file type
new attributes for Score object for capturing meta information
new score note attributes in matchfile export (grace, voice_overlap)
new tempo_indication score property line in matchfile export

Bug Fixes

addresses #293
solves #297
solves #304
solves #306
solves #308
solves #310
solves #315

Other Changes

new unit test for cross-staff beaming for musicxml

huispaty commented 11 months ago

Should we change the version to 1.3.2 or 1.4.0?

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage is 72.97% of modified lines.

Files Changed	Coverage
partitura/directions.py	`ø`
partitura/io/matchlines_v1.py	`ø`
partitura/score.py	`39.02%`
partitura/io/matchfile_utils.py	`41.17%`
partitura/io/musescore.py	`42.30%`
tests/test_pianoroll.py	`50.00%`
partitura/io/exportmatch.py	`52.38%`
partitura/io/exportmidi.py	`66.66%`
partitura/io/importmei.py	`67.30%`
partitura/performance.py	`71.69%`
... and 13 more

:loudspeaker: Thoughts on this report? Let us know!.

sildater commented 11 months ago

A general question, this PR links issue #293 which is not really addressed. The same behavior that was mentioned still persists. However, we probably also won't change it, so I just tried to give some details around it. How should we handle this? Should we keep this open? Or have some kind of FAQ section somewhere? I sometimes write these longer explanations on issues and would like them to stay around somewhere after we close the issue.