search

CPJKU / partitura

A python package for handling modern staff notation of music
https://partitura.readthedocs.io
Apache License 2.0
227 stars 15 forks source link

solution without dummies #334

Closed sildater closed 10 months ago

sildater commented 10 months ago

I found a solution for correct match line parsing that doesn't involve dummies, but additional identifying patterns that are independent of the match(s)note class and its version.

sildater commented 10 months ago

also a minor change to discard unparseable lines, i.e., if parse_matchlines finds no matching pattern, it returns None, but we don't want these in the matchfile.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
partitura/io/exportmatch.py 79.79% <100.00%> (ø)
partitura/io/importmatch.py 82.27% <100.00%> (-0.79%) :arrow_down:
partitura/io/matchfile_base.py 94.94% <100.00%> (+0.10%) :arrow_up:
partitura/io/matchfile_utils.py 94.89% <100.00%> (+0.01%) :arrow_up:
partitura/io/matchlines_v0.py 86.14% <100.00%> (+0.24%) :arrow_up:
tests/test_match_import.py 99.85% <66.66%> (-0.15%) :arrow_down:

:loudspeaker: Thoughts on this report? Let us know!.