Closed manoskary closed 1 month ago
Attention: Patch coverage is 82.29376%
with 88 lines
in your changes missing coverage. Please review.
Project coverage is 82.27%. Comparing base (
3cd1e41
) to head (c867eb2
). Report is 87 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The PR is good, I'm requesting some cosmetic changes for better code readability.
Import for DCML corpora tsv files
DONE
music.py
.partitura.utils.music
to separate script calledpartitura.utils.globals
to avoid circular import errors. (This will be done in a following PR after this one is merged to not break other components).TODOs (For new PRs)
numpy.genfromtxt
. It can be done but the process is much more complicated because it transforms many strings to byte strings and it will take some major restructuring. For now the code raises a warning that pandas is required. For the future, we replace withnumpy.genfromtxt
and replace the warning. A relevant Issue will be opened.