CPJKU / partitura

A python package for handling modern staff notation of music
https://partitura.readthedocs.io
Apache License 2.0
227 stars 15 forks source link

Dcml annotation parser #345

Closed manoskary closed 1 month ago

manoskary commented 7 months ago

Import for DCML corpora tsv files

DONE

TODOs (For new PRs)

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 82.29376% with 88 lines in your changes missing coverage. Please review.

Project coverage is 82.27%. Comparing base (3cd1e41) to head (c867eb2). Report is 87 commits behind head on develop.

Files Patch % Lines
partitura/score.py 76.52% 50 Missing :warning:
partitura/io/importdcml.py 89.61% 16 Missing :warning:
partitura/utils/music.py 64.86% 13 Missing :warning:
partitura/io/exportmusicxml.py 25.00% 6 Missing :warning:
partitura/io/importmusicxml.py 33.33% 2 Missing :warning:
tests/test_dcml_import.py 92.30% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #345 +/- ## =========================================== - Coverage 84.11% 82.27% -1.84% =========================================== Files 82 88 +6 Lines 14506 15440 +934 =========================================== + Hits 12202 12704 +502 - Misses 2304 2736 +432 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fosfrancesco commented 2 months ago

The PR is good, I'm requesting some cosmetic changes for better code readability.