search

CPJKU / partitura

A python package for handling modern staff notation of music
https://partitura.readthedocs.io
Apache License 2.0
227 stars 15 forks source link

utils.music.get_time_maps_from_alignment removed from API without updating partitura.readthedocs.io #348

Open eoinroe opened 7 months ago

eoinroe commented 7 months ago

The example code from here has not been updated so when running it with the latest version of Partitura it produces the following error:

AttributeError: module 'partitura.utils.music' has no attribute 'get_time_maps_from_alignment'

It appears that get_time_maps_from_alginment has been completely removed from the API instead of being deprecated so it is unclear which method to use in its place.

neosatrapahereje commented 7 months ago

Good catch! The method was moved to the performance_codec module (in musicanalysis) and can be accessed as follows:

from partitura.musicanalysis.performance_codec import get_time_maps_from_alignment

We'll update the tutorial and have a deprecation notification in utils.music to fix this issue.

eoinroe commented 7 months ago

Thanks for your swift reply! I am now able to run the code from the tutorial and recreate the plot using match files from the Vienna 4x22 Piano Corpus.

Cheers!

github-actions[bot] commented 1 month ago

This issue had no activity for 6 months. It will be closed in 2 weeks unless there is some new activity. Is this issue already resolved?