CPJKU / partitura

A python package for handling modern staff notation of music
https://partitura.readthedocs.io
Apache License 2.0
227 stars 15 forks source link

Mei export [AGAIN!] #350

Closed manoskary closed 6 months ago

manoskary commented 6 months ago

This PR solves some relatively important issues that were overlooked with MEI export.

Thank you.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 28.51406% with 178 lines in your changes are missing coverage. Please review.

Project coverage is 84.16%. Comparing base (018f264) to head (3af8604). Report is 1 commits behind head on develop.

Files Patch % Lines
partitura/score.py 8.33% 143 Missing :warning:
partitura/io/exportmei.py 50.00% 33 Missing :warning:
partitura/io/importmusicxml.py 95.83% 1 Missing :warning:
partitura/utils/music.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #350 +/- ## =========================================== - Coverage 84.96% 84.16% -0.80% =========================================== Files 82 82 Lines 14236 14471 +235 =========================================== + Hits 12096 12180 +84 - Misses 2140 2291 +151 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

manoskary commented 6 months ago

Some issues with unmarked commits re-opening the PR