search

CPJKU / partitura

A python package for handling modern staff notation of music
https://partitura.readthedocs.io
Apache License 2.0
227 stars 15 forks source link

Estimate symbolic duration for Composite durations #352

Closed manoskary closed 3 months ago

manoskary commented 6 months ago

This PR addresses a minor improvement on symbolic duration estimation for composite duration, i.e. tied notes or multiple rests. We make this a standard on the rest infilling function in score.py and we generally make this an option. The PR includes some improved documentation.

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 16.21622% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 83.02%. Comparing base (3cd1e41) to head (711b5c3). Report is 1 commits behind head on develop.

Files Patch % Lines
partitura/score.py 0.00% 37 Missing :warning:
partitura/io/exportmei.py 4.16% 23 Missing :warning:
partitura/io/importmusicxml.py 50.00% 1 Missing :warning:
partitura/utils/music.py 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #352 +/- ## =========================================== - Coverage 84.11% 83.02% -1.10% =========================================== Files 82 82 Lines 14506 14562 +56 =========================================== - Hits 12202 12090 -112 - Misses 2304 2472 +168 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.