search

CPLUOS / nano

nanoAOD tools for production and analysis
https://github.com/CPLUOS/nano/wiki
5 stars 12 forks source link

Remove topAnalysis.h #78

Closed tt8888tt closed 6 years ago

tt8888tt commented 6 years ago

If both event selection and object selection are different for DL (dilepton), SL (semilepton), can we just remove topAnalysis.h and use something like dileptonTopAnalysis.h and semileptonTopAnalysis.h instead?

watson-ij commented 6 years ago

The only difference at the moment between DL and SL object selection is the lepton pt cut. Is the flag bothering you that much?

tt8888tt commented 6 years ago

not at all. just there was an opinion that it has too many steps. currently, we're inheriting Events.h->nanoAnalysis.h->topAnalysis.h->semileptonAnalysis.h->hadron.h... but do we really need this much?

tt8888tt commented 6 years ago

then I will rename the codes something like,

this...?