This is a review of the overall functionality of the lastest version. I'm finding a bunch of things compromised, so I'm gonna lump them together here.
Also, I'm gonna rate them as H-high, M-medium & L-low with regard to importance of fixing before my Thursday visit to Napa for the Bohemian
All of my changes are clearly marked // temp fix CPL for ease of identification
FIXED 0) H - SetupView Route picker - The route picker still appears to be linked to Name instead of Driver. Changed - (void)caculatorRouterPicker obj to @"Driver".FIXED 1) H - MapView - User location blue button does not appear anymore. Commented out userLocation for calculateCenter method & set self.mapView.showsUserLocation = true;
2) M - DetailView Directions button. This button now takes you directly to Apple maps instead of to a mapView with only the single pin displayed, as was before. All we wanted to do was change the text of the button from Map to Directions, NOT change the navigation. Swap - (IBAction)directions:(id)sender method back to where it came MapView?
3) H - HomeView - Route statistics appear broken. The statistics are perfect on the SetupView, but they do NOT show the current statistics on the HomeView
4) H - DetailView - Editing appears broken. When you edit a field (say Comment) then leave the detail screen for MapView. When you go back to the same detailView you should see the edtied value. This is currently no longer working? The Comment & Notes TextView do NOT trigger the save of the edited file. The textFields do as all the fields should. This conditional needs to be changed if (self.textFieldChanged) add compare original & current Notes, Comment & Phone textViews AND set self.textFieldChanged = TRUE; IF not equal, Can we base the trigger on everytime we dismiss the keyboard?
5) H - MapView zooming. The zooming appears to still have same "unzoom" behavior. Also, when going from the HomeView to MapView the filter is cleared & the zoom goes back to full extents? It appears that the new conditional code using list_detail_enter in viewWill & DidAppear methods needs a little tweeking.
6) M - SetupView - When selecting a new file all views should reflect the new file, and the route should be set for all. Currently if your previous file was filtered, and you select a new file, the filter does NOT clear to All. Also, in the list view the list does not update.
7) H - SetupView - The bundles var is initially zero & therefore crashes the app when this is executed bundles = copies/v; Need to set an initial value (50) for this var UserDefault = copies_bundle
DELETE 8) L - SetupView - If the bundles value is greater than it's Integer value(ie 8.25 > 8) THEN add 1 to the bundle value. Not worth doing.
9) L - SetupView - The routePicker set needs to be in alphabetic order.
10) L - SetupView - The email & bundle textFields show show current values whenever the view is displayed.
11) M - DetailView - The DONE button on the keyboard for textFields works GREAT. But the numeric fields & textView field need to work the sane way. Need to check all data entry fields.
12)
liangdev
commented
8 years ago
This is a review of the overall functionality of the lastest version. I'm finding a bunch of things compromised, so I'm gonna lump them together here. Also, I'm gonna rate them as H-high, M-medium & L-low with regard to importance of fixing before my Thursday visit to Napa for the Bohemian All of my changes are clearly marked // temp fix CPL for ease of identification
FIXED 0) H - SetupView Route picker - The route picker still appears to be linked to Name instead of Driver. Changed - (void)caculatorRouterPicker obj to @"Driver". FIXED 1) H - MapView - User location blue button does not appear anymore. Commented out userLocation for calculateCenter method & set self.mapView.showsUserLocation = true; 2) M - DetailView Directions button. This button now takes you directly to Apple maps instead of to a mapView with only the single pin displayed, as was before. All we wanted to do was change the text of the button from Map to Directions, NOT change the navigation. Swap - (IBAction)directions:(id)sender method back to where it came MapView? 3) H - HomeView - Route statistics appear broken. The statistics are perfect on the SetupView, but they do NOT show the current statistics on the HomeView 4) H - DetailView - Editing appears broken. When you edit a field (say Comment) then leave the detail screen for MapView. When you go back to the same detailView you should see the edtied value. This is currently no longer working? The Comment & Notes TextView do NOT trigger the save of the edited file. The textFields do as all the fields should. This conditional needs to be changed if (self.textFieldChanged) add compare original & current Notes, Comment & Phone textViews AND set self.textFieldChanged = TRUE; IF not equal, Can we base the trigger on everytime we dismiss the keyboard? 5) H - MapView zooming. The zooming appears to still have same "unzoom" behavior. Also, when going from the HomeView to MapView the filter is cleared & the zoom goes back to full extents? It appears that the new conditional code using list_detail_enter in viewWill & DidAppear methods needs a little tweeking. 6) M - SetupView - When selecting a new file all views should reflect the new file, and the route should be set for all. Currently if your previous file was filtered, and you select a new file, the filter does NOT clear to All. Also, in the list view the list does not update. 7) H - SetupView - The bundles var is initially zero & therefore crashes the app when this is executed bundles = copies/v; Need to set an initial value (50) for this var UserDefault = copies_bundle DELETE 8) L - SetupView - If the bundles value is greater than it's Integer value(ie 8.25 > 8) THEN add 1 to the bundle value. Not worth doing. 9) L - SetupView - The routePicker set needs to be in alphabetic order. 10) L - SetupView - The email & bundle textFields show show current values whenever the view is displayed. 11) M - DetailView - The DONE button on the keyboard for textFields works GREAT. But the numeric fields & textView field need to work the sane way. Need to check all data entry fields. 12)