[FEATURE] Use DDEV's .ddev/.env feature instead of setting TYPO3_CONTEXT within DDEV config.yaml

CPS-IT / typo3-project-template

Project builder template for TYPO3 CMS projects with configuration for DDEV and Deployer

GNU General Public License v3.0

10 stars 1 forks source link

[FEATURE] Use DDEV's .ddev/.env feature instead of setting TYPO3_CONTEXT within DDEV config.yaml #16

Open josefglatz opened 1 year ago

josefglatz commented 1 year ago

Is your feature request related to a problem?

no, just a new feature of ddev

Describe the solution you'd like

Describe alternatives you've considered

Additional context

It's technically not really needed. But I think it makes sense if someone uses .env very often in projects.

eliashaeussler commented 1 year ago

Hi @josefglatz, thanks for your feature request!

I really like the idea. However, since the .ddev/.env compatibility is relatively new (only available in the latest version), I'd suggest to keep the "legacy" behavior in .ddev/config.yaml next to the integration of a .ddev/.env file. Once the new behavior has established, we can safely drop the old web_environment implementation.

Are you willing to provide a PR?

josefglatz commented 3 months ago

Do you think this feature has established now?

eliashaeussler commented 3 months ago

Since I don't make use of this feature, I cannot tell about how popular it is and if it's something people are actually using in their projects. However, I can see that it's properly documented in the latest DDEV documentation. AFAICS, this feature was added 1,5 years ago with DDEV v1.21.4 (ddev/ddev#4418), which is long ago and therefore should be available to the vast majority of DDEV users. So, from my side and if you're willing to implement it: Go for it 🚀