search

CPSSD / LUCAS

The repository for the LUCAS/Lucify project
MIT License
11 stars 4 forks source link

Added Review badges #183

Closed KirillSloka closed 5 years ago

KirillSloka commented 5 years ago

blah

The current badges are from left to right. Green Star average user rating is 2 stars and more, Red Star average rating is below 2 stars. Chees Pieces are Pawn, Rook and Queen define how many Reviews the user has written. Pawn is less than 5 Rook is more than 5 and less than 20 and queen is 20 or more. Calendar badge has 2 colours green means the users has an even spread of reviews across dates red means the user has more review done in one day then the next 4 days with the most amount of reviews. Pencil show in red when average review length is less than 140 green means its more.

I am looking for feedback for the Icons used and if you would like to tweak any of the numbers or anything else

Also updated our Mongo instance to have a username and password. The frontend side it is hidden but if someone can take up to hide it on the python side that would be greatly appreciated.

UPDATE: Added some tooltips

KirillSloka commented 5 years ago

Tooltips are coming tomorrow

Deniall commented 5 years ago

Awesome work man. Excited to test this out for myself.

KirillSloka commented 5 years ago

Oh oops the credentials are gone will fix in a sec accidentally commit the wrong things

KirillSloka commented 5 years ago

That line is not a badge its just tooltip text

KirillSloka commented 5 years ago

Forgot to add it to the environment.yml as a dependency. Reload the environment or just do pip install pymongo

KirillSloka commented 5 years ago

Done

StefanKennedy commented 5 years ago

Why do we show badges no matter what? Shouldn't we only show it if it's indicating deception?

KirillSloka commented 5 years ago

Why do we show badges no matter what? Shouldn't we only show it if it's indicating deception?

That was never the indented approach. Even based on our discussion during the last sprint meeting

Deniall commented 5 years ago

The badges were meant to give some more transparency into the review. I think if we say a review is genuine, it's beneficial to show badges that may indicate why

StefanKennedy commented 5 years ago

What if it's not an indicator of anything though?

KirillSloka commented 5 years ago

We can refine the idea of badges further later on next sprint if you want but the current design is done.

Deniall commented 5 years ago

There does need to be some design iterations and tweaks but we don't really have any time left to do those. I think it works for a first design and I'm happy to merge for the sake of sprint completion.