search

CPSSD / robots

CA224 robotics project
4 stars 0 forks source link

Simulator #132

Closed formal closed 8 years ago

formal commented 8 years ago
  1. Bug fixes.
  2. More complex topologies for rooms.
  3. Define and use a room class
  4. Add an option to add random errors.
cgmc commented 8 years ago

What would be your thoughts on my creating separate issues for each of the above points? I think there is enough in each sub-issue to warrant it, plus it would allow for a more granular tracking of progress.

DarraghGriffin commented 8 years ago

I definitely think we can split this into sub issues. It could be a way to improve on the issues we had with code reviewing everything in the last few days last sprint.

cgmc commented 8 years ago

But don't we do code reviews on pull requests? If we wanted to avoid a mega-review near the end of the sprint, when I would usually pull request from the Simulator branch into master, wouldn't I have to have sub-branches for each sub-issue, so that we could do a code review on each pull request into the Simulator branch? I mean, it could work, but I can foresee a situation where the same file is modified differently in different sub-branches, and that could be a headache and a half to manage.