search

CPqD / ofsoftswitch13

OpenFlow 1.3 switch.
http://cpqd.github.com/ofsoftswitch13
304 stars 192 forks source link

Link Up problem is solved #292

Open abakagamze opened 5 years ago

abakagamze commented 5 years ago

Hi Everyone,

The problem steps:

  1. Run ONOS (the sdn controller)
  2. Run Mininet with this switch implementation
  3. Run "link s1 h1 down" -> it creates PORT_STATUS message and ONOS makes this port "disabled". This message includes "OFPPC_PORT_DOWN=True" and "OFPPS_LINK_DOWN=True"
  4. Run "link s1 h1 up" -> it creates PORT_STATUS message and the port is still "disabled" because of the wrong parameter of this message.

PORT_STATUS message is received with "OFPPC_PORT_DOWN=False" and "OFPPS_LINK_DOWN=True" - but link down parameter must be false to enable the port again.

I've fixed it changing the wrong bit setting. Now it works.

Best Regards,

ederlf commented 5 years ago

Thank you very much for you contribution. :-)

Can I ask you if you could possibly clean your pull request only with commits relevant to the problem being solved? There are a few merges and a fix for another bug which are not directly related to the pull request. The form it is submitted does not make it easy to understand all changes and what the patches are solving.

abakagamze commented 5 years ago

Hi, You see multiple commits but if you check the file changes, you can see the relevant update. (there is a minor change) Actually, I dont know how to clean my pull request. -- Please note that my other commits are related to meter bug fix that was already merged. BR,

ederlf commented 5 years ago

Hi, I do really appreciate the contribution, but it does not help me that much if the pull request is done that way as I do not have time to look every commit and search what is relevant. If it is only a small change you would like to be pushed, you could have opened an issue for it. I will probably cherry-pick the relevant commit to test.

abakagamze commented 5 years ago

Actually, you can cherry-pick only this commit: https://github.com/CPqD/ofsoftswitch13/pull/292/commits/e332e2dcb11dec4e614e62a5b86197d60250ff59