CQC-Scripting / cc-fuel

CC-Fuel is a Modified version of LegacyFuel for QB-Core using QB-Target for Interactions.
https://discord.gg/XdQRbG7JzA
78 stars 25 forks source link

Fuel Level Don't Sync through Players #14

Closed amantu-qbit closed 2 years ago

amantu-qbit commented 2 years ago

If someone Refuels and someone else gets in a vehicle they don't seem to see the same fuel level. Like if someone drive and the fuel is empty and then someone else comes to the driving seat they'll be able to drive and they'll see the default fuel level. The same goes for Refueling.

eoinmcbennett commented 2 years ago

Hi, I think I know what’s causing the issue. I’ll try get a fix out ASAP. Unsure of the ETA currently. Thanks for flagging.

amantu-qbit commented 2 years ago

Hi, I think I know what’s causing the issue. I’ll try get a fix out ASAP. Unsure of the ETA currently. Thanks for flagging.

I would Request you for pushing the fix early. My server is using your fuel script and it's now public and live. So we really need this fix

Quinn101 commented 2 years ago

@amantu-qbit the dev branch currently has a fixed pushed to fix this issue. @eoinmcbennett is going to clean up it up slightly before pushing to the main branch. Let us know if this helps your problems

amantu-qbit commented 2 years ago

@Quinn101 Car from impound and Garage don't have any fuel

eoinmcbennett commented 2 years ago

@Quinn101 Car from impound and Garage don't have any fuel

Check the exports in whatever script you use to impound / unimpound vehicles. cc-fuel does not deal with this directly

amantu-qbit commented 2 years ago

@eoinmcbennett It's an issue with cc-fuel. I changed to previous version and now it's working

Maureks commented 2 years ago

hey ! same issue with me , i've updated cc-fuel , the vehicleshop and the garage give cars with 0 fuel , it was working before the update

EDIT: changed it back to the previous version , and it works well again!

eoinmcbennett commented 2 years ago

Will be looking into this later today

eoinmcbennett commented 2 years ago

@amantu-qbit @Maureks Should be fixed now in the latest commits on dev

Maureks commented 2 years ago

Thanks ! Gonna give it a try !

amantu-qbit commented 2 years ago

@eoinmcbennett Having a new issue. Sometimes players can't target with a gas can in hand. Like it'll not target the vehicle. I got some bug reports from my live server players also I face it myself. But when I spawn any vehicle with admin power it'll always work. On the other hand. My own vehicle/ped vehicle will not work sometimes. IDk what's the issue.

amantu-qbit commented 2 years ago

Or maybe expand Targateable Bones? Not all car have same bones IG

Maureks commented 2 years ago

@amantu-qbit Do you have the qb-target default option for car interaction enabled?

Just asking, because it used to happen to me, and when turned off it worked fine. But this was before the upgrade, I haven't tried it yet!

Thanks for the attention !

amantu-qbit commented 2 years ago

@Maureks Yup it's enabled

amantu-qbit commented 2 years ago

@Maureks Just Adding Bonnet/doors to cc fuel bones for testing

amantu-qbit commented 2 years ago

@Maureks Some car doesn't have those bone mentioned in cc-fuel config. Adding all doors and bonnet fixed it

Maureks commented 2 years ago

@amantu-qbit Oh cool ! thanks ! Can you give me just an example , I'm kinda new at this sorry !

Thanks in advance !

eoinmcbennett commented 2 years ago

Which car were you testing with and I will try find a fix

amantu-qbit commented 2 years ago

@eoinmcbennett I couldn't fix it with Kawasaki Ninja H2R. Except for this. I fixed for other cars.

eoinmcbennett commented 2 years ago

Fixed with #20