fix!: Ops require their own extension

CQCL / hugr

Hierarchical Unified Graph Representation

Apache License 2.0

15 stars 4 forks source link

closes #388

much less pain than the previous attempt #734 but there is still some pain for FuncDefn's (as there was always going to be) - that's #1237.

Includes adding new variants of block_builder, entry_builder, simple_entry_builder and conditional_builder: the default version omits the extension set parameter, the _exts variant takes an extra parameter (being an ExtensionSet). simple_block_builder is untouched (as it takes a FunctionType, so can use ft1/ft2)

An alternative here would be to keep one variant, but take an exts: impl Into<Option<ExtensionSet>>. This would mean we'd write None for inference, rather than (in this PR) an extra _exts when we don't want inference.
- Using a custom trait (rather than Into<Option<ExtensionSet>>) would allow us to provide impl<T: Into<ExtensionSet>> OurExtensionSetTrait for T so we can use the useful Into<ExtensionSet>s that we have, alongside impl OurExtensionSetTrait for Option so we could still write None.
- Or we could just take exts: impl Into<ExtensionSet> and define some top-level const INFER of a type that impls Into<ExtensionSet> (producing ExtensionSet::singleton(TO_BE_INFERRED)). Then for inference you'd write INFER.
- We expect inference to be the normal hence I think the _exts is a good trade, writing nothing at all beats writing None or INFER

We'll need similar updates to cfg_builder, tail_loop_builder, ConditionalBuilder::new and TailLoopBuilder::new but I'll leave those for another PR, there's quite enough here ;)

BREAKING CHANGE: (1) container-node extension-deltas will need to be enlarged to include ops therein; for FuncDefn this will have to be manually specified but TO_BE_INFERRED (or ft1/ft2 from #1219) works for other containers. (2) block_builder, entry_builder, simple_entry_builder and conditional_builder no longer take an ExtensionSet; either drop the argument or use the ..._exts variant.

Files	Patch %	Lines
hugr-passes/src/nest_cfgs.rs	0.00%	0 Missing and 12 partials :warning:
hugr-core/src/builder/dataflow.rs	62.50%	0 Missing and 6 partials :warning:
hugr-core/src/hugr/rewrite/simple_replace.rs	60.00%	0 Missing and 4 partials :warning:
hugr-core/src/builder/cfg.rs	94.44%	0 Missing and 3 partials :warning:
hugr-core/src/hugr/rewrite/replace.rs	71.42%	0 Missing and 2 partials :warning:
hugr-passes/src/merge_bbs.rs	0.00%	0 Missing and 2 partials :warning:
hugr-core/src/extension/op_def.rs	91.66%	0 Missing and 1 partial :warning:
hugr-core/src/hugr/rewrite/outline_cfg.rs	0.00%	0 Missing and 1 partial :warning:
hugr-core/src/hugr/serialize/test.rs	0.00%	0 Missing and 1 partial :warning:
hugr-core/src/hugr/validate/test.rs	92.30%	0 Missing and 1 partial :warning:
... and 1 more

Files

Patch %

Lines

hugr-passes/src/nest_cfgs.rs

0.00%

0 Missing and 12 partials :warning:

hugr-core/src/builder/dataflow.rs

62.50%

0 Missing and 6 partials :warning:

hugr-core/src/hugr/rewrite/simple_replace.rs

60.00%

0 Missing and 4 partials :warning: