Rename 'Rewrite' - Githubissues

CQCL / hugr

Hierarchical Unified Graph Representation for quantum and classical programs

https://crates.io/crates/hugr

Apache License 2.0

17 stars 5 forks source link

Rename 'Rewrite' #588

Open acl-cqc opened 11 months ago

acl-cqc commented 11 months ago

This causes too much confusion with the idea of a rewrite rule (being a pattern to look for anywhere plus some replacement). The Hugr 'Rewrite' (trait, implemented by SimpleReplacement, etc.) is a lower-level thing. Maybe Modification or HugrMutation?? (oh, HugrMut. Hmmmm.)

ss2165 commented 10 months ago

How about Patch?

ss2165 commented 10 months ago

Edit as suggested by @cqc-alec

(And variations of such, e.g. LocalEdit)

acl-cqc commented 10 months ago

I think Patch is very good.

Seems the right sort of level of abstraction
Captures that it's quite closely fixed to the structure of the Hugr but not totally fixed to exactly one Hugr.

Ok, downsides

doesn't suggest an interface with multiple implementations, but those are just different ways of storing/representing a patch (using different code and data)
Our "Rewrites" are maybe not quite as general as UNIX text-file patches (which can encapsulate any change to a single file)