search

CQCL / protoc-gen-pyproject

A simple protoc plugin to copy and expand python project files.
Apache License 2.0
2 stars 0 forks source link

proto3_optional not reported as supported #1

Open johnchildren opened 1 year ago

johnchildren commented 1 year ago

When running buf generate along with betterproto on a project that requires proto3_optional we get a warning:

Warning: plugin "pyproject" does not support required features.
  Feature "proto3 optional" is required by 7 file(s):

Technically we do support this feature as we don't actually generate any source code, so we could be reporting it as a supported feature in our response to the protoc grpc call to the plugin.

johnchildren commented 1 year ago

Looks like it should just be a matter of doing as betterproto does: https://github.com/danielgtaylor/python-betterproto/blob/0adcc9020cf738489e8b21efc653bd883b12d4af/src/betterproto/plugin/parser.py#L72