search

CQCL / pytket-braket

pytket-braket, extensions for pytket quantum SDK
Apache License 2.0
2 stars 2 forks source link

Add example notebook for braket setup and simple circuit #61

Open dbcq opened 1 year ago

dbcq commented 1 year ago

Amazon braket documentation is sometimes not very clear, and pytket-braket doesn't have as much documentation as some other pytket extensions. This notebook is based on a Confluence page I wrote for our team and on a notebook by Callum. I have used the notebook template and generation from pytket-quantinuum.

dbcq commented 1 year ago

Could you advise what to do about the failed linting? I assume it comes from the long 'comments' which are turned into markdown cells by p2j. pytket-quantinuum seems to have the same formatting but appears to lint fine, but I couldn't see any particular options which were being used there

cqc-alec commented 1 year ago

Could you advise what to do about the failed linting? I assume it comes from the long 'comments' which are turned into markdown cells by p2j. pytket-quantinuum seems to have the same formatting but appears to lint fine, but I couldn't see any particular options which were being used there

Yes it seems to be coming from the long lines. Can you wrap the lines at 80 characters. or does that break the p2j conversion? If necessary we can exclude the folder from the link check.

dbcq commented 1 year ago

Yes, p2j treats each line break as a new markdown cell so it doesn't look the best. I assume in pytket-quantinuum they're simply excluded from the linting check

cqc-alec commented 1 year ago

Yes, p2j treats each line break as a new markdown cell so it doesn't look the best. I assume in pytket-quantinuum they're simply excluded from the linting check

Actually they are not excluded there, and the python files do contain long lines (e.g. https://github.com/CQCL/pytket-quantinuum/blob/develop/examples/python/Quantinuum_circuit_submissions.py ), so I am not sure what's different here...

CalMacCQ commented 1 year ago

I think it'd be nice to have an example as some of the syntax for pytket-braket can be confusing. Should we finish this off?

cqc-alec commented 1 year ago

I think it'd be nice to have an example as some of the syntax for pytket-braket can be confusing. Should we finish this off?

Sure, I think it's just some linting issues to fix?

cqc-alec commented 5 months ago

Please rebase and retarget to main which is now the default branch.