Closed CalMacCQ closed 4 months ago
One formatting error, one typo, and one minor comment. Otherwise this is a very good change that helps readability and approachability.
In reading through the build, I also spotted an additional formatting error on line 1317 (mixing URL and directive links for KAKDecomposition)
Thanks for the review :) I've made the suggested changes and fixed the KAK referencing mistake.
Description
I've done a pass over the
Circuit construction
section of the manual using the circuit renderer in place ofcirc.get_commands()
I've also made some changes to the section on
CircBox
particularly with theCircuit.add_circbox_with_regmap
andCircuit.add_circbox_regwise
methods.I think some of the code examples need to be updated too. Maybe thats best done in another PR.
closes #331