CQCL / pytket-iqm

pytket-iqm, extensions for pytket quantum SDK
Apache License 2.0
2 stars 4 forks source link

Feature/pr49 #50

Closed cqc-alec closed 1 year ago

cqc-alec commented 1 year ago

@ollityrkko I replicated your PR here to allow the github secrets to be accessed ...

cqc-alec commented 1 year ago

@ollityrkko It looks like there is a connection error; do we need to update the credentials?

ollityrkko commented 1 year ago

I believe the problem is with the auth server URL which has changed. I made the corresponding change in README. Auth server URL is apparently stored also in the secrets.

From: Alec Edgington @.> Date: Tuesday, 28. March 2023 at 16.29 To: CQCL/pytket-iqm @.> Cc: Olli Tyrkkö @.>, Mention @.> Subject: Re: [CQCL/pytket-iqm] Feature/pr49 (PR #50) NOTE: This e-mail originates from outside IQM, exercise caution with any instructions in the content, attachments or links.


@ollityrkkohttps://github.com/ollityrkko It looks like there is a connection error; do we need to update the credentials?

— Reply to this email directly, view it on GitHubhttps://github.com/CQCL/pytket-iqm/pull/50#issuecomment-1486890266, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXM526F5AYVJQBVNBFFPP2LW6LRRRANCNFSM6AAAAAAWKSHM3Q. You are receiving this because you were mentioned.Message ID: @.***>

cqc-alec commented 1 year ago

I believe the problem is with the auth server URL which has changed. I made the corresponding change in README. Auth server URL is apparently stored also in the secrets.

Right, thanks, I'll update the URL in the secrets...

cqc-alec commented 1 year ago

Thanks for the fixes, this looks good to me.

cqc-alec commented 1 year ago

Looks good, should we do a release soon?

Yes I think so.