search

CQCL / pytket-qir

Public repo for the pytket-qir package
Apache License 2.0
6 stars 1 forks source link

add SU4 gate, update pytket #43

Closed cqc-melf closed 1 year ago

cqc-melf commented 1 year ago

I don't understand why we are introducing this radians-conversion logic here when it should already exist for other parametrized rotation gates. Is it a bug that we are not converting those?

I have not added any parameter conversion for the gates. I will add them now. Is this something that is defined in the QIR profile or is that back end specific?

cqc-alec commented 1 year ago

I don't understand why we are introducing this radians-conversion logic here when it should already exist for other parametrized rotation gates. Is it a bug that we are not converting those?

I have not added any parameter conversion for the gates. I will add them now. Is this something that is defined in the QIR profile or is that back end specific?

I can't find chapter and verse, but am fairly certain it's general. As far as I know pytket is the only software that uses half-turn units for rotation angles.

cqc-melf commented 1 year ago

I don't understand why we are introducing this radians-conversion logic here when it should already exist for other parametrized rotation gates. Is it a bug that we are not converting those?

I have not added any parameter conversion for the gates. I will add them now. Is this something that is defined in the QIR profile or is that back end specific?

I can't find chapter and verse, but am fairly certain it's general. As far as I know pytket is the only software that uses half-turn units for rotation angles.

Sounds plausible, I was thinking if we should add a parameter for this in the API, but I have not done this, assuming that no device would want that.

cqc-melf commented 1 year ago

(I will put out another RC after this is merged and check that with pytket-quantinuum)