search

CQCL / pytket-qir

Public repo for the pytket-qir package
Apache License 2.0
6 stars 1 forks source link

Feature/measure to reg #87

Closed cqc-melf closed 10 months ago

cqc-melf commented 10 months ago

Not sure what the name is er agreed on, happy to update this.

qartik commented 10 months ago

Not sure what the name is er agreed on

Given the interface in https://github.com/CQCL/pytket-qir/pull/61#pullrequestreview-1567770240 perhaps a better name might be measure_to_creg or mz_to_creg in short?

cqc-melf commented 10 months ago

Not sure what the name is er agreed on

Given the interface in #61 (review) perhaps a better name might be measure_to_creg or mz_to_creg in short?

I have done a rename to mz_to_creg

qartik commented 10 months ago

Hi @cqc-melf, it's not clear to me from a quick look whether mz_to_creg is supposed to measure a single qubit or a register of qubits or both. Can you clarify?

If it's a single bit (that I suspect from the third argument of creg index), then the name could be misleading. In that case, I'd prefer it be called mz_to_creg_bit.

cqc-melf commented 10 months ago

Yes the plan is to measure one qubit to the bit entry of a register, I have added an additional comment and renamed like suggested