CQCL / pytket-qiskit

pytket-qiskit, extensions for pytket quantum SDK

Apache License 2.0

16 stars 13 forks source link

Add conversion of controlled unitary gates from Qiskit to TKET. #372

Closed gkpotter closed 2 months ago

gkpotter commented 2 months ago

Description

Add support for converting controlled unitary gates from Qiskit to TKET.

Related issues

Please mention any github issues addressed by this PR.

Checklist

[x] I have performed a self-review of my code.
[x] I have commented hard-to-understand parts of my code.
[ ] I have made corresponding changes to the public API documentation.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have updated the changelog with any user-facing changes.

Notes

I have yet to update the changelog/API docs, in case more changes or refactoring are required.

cqc-melf commented 2 months ago

Hi @gkpotter Thank you for the PR. There is one issues with the format check, could you take care of this? Besides that it is looking good.

CalMacCQ commented 2 months ago

I think its just a case of running the black formatter on the qiskit convert file

black qiskit_convert.py

gkpotter commented 2 months ago

Oops sorry about that. Just re-ran black on qiskit_convert.py!

cqc-melf commented 2 months ago

Looks good, I have run the checks locally and they all work. It would be nice to add the conversion in the other direction, too. If you don't have the time to do that, I will add an issue for that and try to do it in the near future.

If you don't want to add the other direction, please update the changelog and I am happy to approve this.

gkpotter commented 2 months ago

I updated the changelog. Unfortunately, right now I do not have time to implement conversion in the other direction.

CalMacCQ commented 2 months ago

I updated the changelog. Unfortunately, right now I do not have time to implement conversion in the other direction.

Thanks for the useful contribution @gkpotter :) This reminded me that the qiskit conversion code should be refactored.

@cqc-melf Are you fine with this being merged now?

cqc-melf commented 2 months ago

I have added an issue for that, https://github.com/CQCL/pytket-qiskit/issues/378

CalMacCQ commented 1 month ago

@gkpotter This should now be in the 0.56 release. Thanks again for adding this.