CQCL / pytket-qiskit

pytket-qiskit, extensions for pytket quantum SDK
Apache License 2.0
17 stars 13 forks source link

Use `AutoRebase` in `tk_to_qiskit` rather than `RebaseCustom` #387

Closed CalMacCQ closed 2 months ago

CalMacCQ commented 2 months ago

Description

Replaces the rebase pass in the tk_to_qiskit conversion with AutoRebase. It doesn't require a tk1_replacement function and so it better from the point of view of serialization. Its also a bit cleaner syntatically and allows us to delete some unecessary lines which define variables for RebaseCustom.

This PR supercedes CQCL/pytket-qiskit#386 as I don't see a reason for this to wait until the refactor of tk_to_qiskit and qiskit_to_tk is done.

As mentioned in the related issue, I'm a little puzzled that this shows up in the dict of the default_compilation_pass for IBM backends. I think it would be worth checking to see if the passes are serilaized correctly.

(please see the issue discussion CQCL/tket#1573)

Related issues

CQCL/tket#1573

Checklist