Wasm encoding is not defined on the json schema

CQCL / tket

Source code for the TKET quantum compiler, Python bindings and utilities

https://docs.quantinuum.com/tket/

Apache License 2.0

257 stars 48 forks source link

Wasm encoding is not defined on the json schema #1505

Open aborgna-q opened 3 months ago

aborgna-q commented 3 months ago

The wasm field in encoded operations does not appear in the schema. https://github.com/CQCL/tket/blob/develop/schemas/circuit_v1.json

As @johnchildren mentions in https://github.com/CQCL/tket-json-rs/issues/61#issuecomment-2258339939,

Honestly if they aren't too set on the schema yet there are some improvements I'd perhaps like to make such as renaming wasm_file_uid to uid

CalMacCQ commented 2 months ago

Is this issue causing problems for tket-json-rs?

aborgna-q commented 1 month ago

We merged a definition that "looks to be alright" in https://github.com/CQCL/tket-json-rs/pull/61, but since the source of truth is deep in the cpp code there is no assurance that it is correct nor that it will remain correct.

A schema validation would probably fail too...