search

CQMP / Maxent

GNU General Public License v2.0
16 stars 14 forks source link

Macports BuildBot reports failure on ppc #16

Closed egull closed 7 years ago

egull commented 7 years ago

Status: Failure Build slave: ports-10.5_ppc_legacy Full logs: https://build.macports.org/builders/ports-10.5_ppc_legacy-watcher/builds/925 Build reason: The SingleBranchScheduler scheduler named 'ports' triggered this build Port list: ALPSMaxent Subport list:

Log from failed builds: Building 'ALPSMaxent' ... [ERROR]

maintainers: egull@umich.edu.

Broken ports:

Responsible maintainers:

Links to individual build jobs:

Best regards, MacPorts Buildbot https://build.macports.org/

egull commented 7 years ago

...the build log states why: unrecognized command line option "-Wno-return-type-c-linkage"

This comes from the line set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O2 -DNDEBUG -Wno-return-type-c-linkage") ...which is set in CMakeLists.txt

[ 5%] Building CXX object CMakeFiles/libmaxent.dir/src/maxent_helper.cpp.o /opt/local/bin/g++-apple-4.2 -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_science_ALPSMaxent/ALPSMaxent/work/build/config -isystem /opt/local/include -I/opt/local/include/eigen3 -pipe -Os -O2 -DNDEBUG -Wno-return-type-c-linkage -msse2 -DNDEBUG -arch ppc -mmacosx-version-min=10.5 -o CMakeFiles/libmaxent.dir/src/maxent_helper.cpp.o -c /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_science_ALPSMaxent/ALPSMaxent/work/Maxent-1.0/src/maxent_helper.cpp cc1plus: error: unrecognized command line option "-Wno-return-type-c-linkage"

ryanlevy commented 7 years ago

The flag is in there from commit 0ac21dbea4b06b81468d637f27368481c6903610 "disabling boost warnings for c type linkage" Should we just remove it for older Apple gcc (<5)?

egull commented 7 years ago

Yes, I think so. I just found it there too... Do you want to do it? @galexv should then do a release with the right auxiliary files and commit to Zenodo, and I'll update their macports file.

ryanlevy commented 7 years ago

Alternatively, we add CHECK_CXX_COMPILER_FLAG(-Wno-return-type-c-linkage SUPPORTS_FLAG) as a more universal check. I'll commit that in and make sure the lack of the flag doesn't cause anything more than inconvenience.

ryanlevy commented 7 years ago

Removing the flag doesn't present a problem for GCC 5, clang 7 on OSX 10.11 and GCC 4.9 and 5 on Ubuntu 15.04. We'll stick with the cmake check for flag compatibility