search

CQMP / Maxent

GNU General Public License v2.0
16 stars 14 forks source link

Find boost::filesystem explicitly #32

Closed galexv closed 7 years ago

galexv commented 7 years ago

...because ALPSCore does not provide it anymore.

ryanlevy commented 7 years ago

I'm confused, I thought I removed all boost::filesystem dependence. Is it lurking somewhere?

galexv commented 7 years ago

I thought I removed all boost::filesystem dependence. Is it lurking somewhere?

For example, here: https://github.com/CQMP/Maxent/blob/0defb322e297e08f6a62027be05953bfc55d7c82/src/maxent.cpp#L23

But if it is the only occurrence, feel free to reject the PR in favor of removing the references to boost FS.

ryanlevy commented 7 years ago

I see, its been properly removed in the GPLv3 branch, but not in the master. @egull how do you think we should proceed?

egull commented 7 years ago

Remove it from the master. I see no reason to have it there if it's gone in GPLv3