search

CQUI-Org / cqui

Civilization 6 - Chao's Quick UI. Reduce clicks and manage your empire faster!
MIT License
317 stars 64 forks source link

'X has conquered Y' omitted from gossip filter menu #517

Open legdrop opened 7 years ago

legdrop commented 7 years ago

Good afternoon, firstly, thank you very much for such a wonderful modification, which I use with the acquisition of the game. But there is a problem - gossip on the screen about AI does not appear at all, just notifications about my studied technologies of culture and science. How can I solve this problem? Or tell me, which file or string I should cut to get rid of the gossip removal function. I'm playing the Russian version of the game. Thank you very much!

chaorace commented 7 years ago

This may be an issue with the heuristic used for intercepting gossips. I did my best to render it language neutral, but there's only so much I can achieve as an English-only speaker.

Hey @e1ectron, does this issue affect you as well?

solo-s commented 7 years ago

Sorry, I can't check it now and in the near future (don't have access to actual game version).

solo-s commented 7 years ago

Hey, @chaorace. Test it on a 1.0.4 (1.0.0.129) Mac version on Russian and English. For a hour, I haven't seen any gossips. So problem is not the language.

May be platform? @legdrop, you play on Win or Mac?

legdrop commented 7 years ago

Windows 10, 64 bit.

bollbas commented 7 years ago

I think @legdrop wants to read popup gossips that appear on vanilla on center of the screen. If so you need to remove line 35 in UI/Panels/StatusMessagePanel.lua that was added on this commit f04d0b5e0ff387a80420ccb0009865df134fc524

legdrop commented 7 years ago

@bolbass Yes, you understood everything correctly, thank you all very much! I do not have the option now to run the game, but please check, I selected the correct code to delete? 1

bollbas commented 7 years ago

Don't delete it :) The commit I mentioned above was already fixed in CQUI so my last comment was wrong.

The last commits that affect gossips are c8963130252a8cb90546423564eb6c22911e64ea and f9d919e0ee0bbad444653670c5ff1273ead85d7b. And this commit 6c3094073d928de47db3a87615267b8efc7ad105 affects the size of gossip messages. The result of these commits is that you can choose gossips you want to see or disable on CQUI settings that are above the minimap. Have you tried changing it to turn on all the gossips? I've tested CQUI gossip settings a bit and couldn't find a gossip when other civs enter new era for example. To see all the gossips you can also try to manually delete lines 284-293 in StatusMessagePanel.lua On a picture above you've already selected them but first 4 lines should stay. You should start deleting from if (type == ReportingStatusTypes.GOSSIP) then

legdrop commented 7 years ago

Thanks a lot, it works!

chaorace commented 7 years ago

Okay... so did we ever figure out if this issue was caused by CQUI not correctly showing gossips?

bollbas commented 7 years ago

Yes, there is at least one type of gossips that is missing on gossips settings screen (a gossip when other civs enter new era for example).

bollbas commented 7 years ago

This type of gossips is now under "City>>X has counquered Y" settings. We should fix it and can close this issue as soon as it's enough to unchek "Trim gossip messages" to see all the gossips. And maybe we need to edit a tooltip for this setting because it's not obvious that all gossips will be shown if we uncheck it.