search

CQUI-Org / cqui

Civilization 6 - Chao's Quick UI. Reduce clicks and manage your empire faster!
MIT License
318 stars 64 forks source link

Naturalist Lens #562

Closed pspjuth closed 7 years ago

pspjuth commented 7 years ago

This adds a Naturalist Lens to help localise where National Parks can be built. It extends the Naturalist from MoreLenses by highlighting potential tiles that could become a Park except for something simple such as removing an improvement or change ownership.

pspjuth commented 7 years ago

@bolbass, I don' t understand your 2). Regarding 1), I prefer to know if bordering tiles are worthy. I'm not above stealing a tile for a good park. However, buying a neutral tile is quite different from conquering one, so having another hue for those owned by someone else might be prudent.

bollbas commented 7 years ago

@pspjuth, regarding 2): in your method any tile with >=2 appeal will be highlighted as a "ok" or "fixable" tile even if it's surrounded with 6 districts and can never be used for National Park. That's why first we need to check if all 4 tiles that can organize a National Park are "ok" or "fixable" and then highlight all of them in that case. regarding 1): it's a bit strange to see "fixable" tiles near other civ's capitals or other cities. I think that conquering these cities is a much harder "fix" than adding neutral territory to your civ. By the way sometimes we don't even know what city a tile belongs to.

pspjuth commented 7 years ago

@bolbass, I see what you mean and I agree that would be ideal.

However, I think it now has a good balance between complexity and usefulness. The current implementation is dead simple since it analyses single tiles, and very useful since it is trivial to disregard the impossibilities and see the diamonds.

Extending the analysis to look at neighboring tiles would create a new category of "fixable", where appeal can be increased by removing mines, planting forests etc. The list of possibilities there is rather large and getting it fully right would be tricky. But I have some ideas running through my mind, I'll see what I can do.

pspjuth commented 7 years ago

@bolbass, With this addition the clutter should be less while still providing good information.

bollbas commented 7 years ago

And by the way More Lenses taken to CQUI from the More Lenses mod so it's better to commit changes there also

chaorace commented 7 years ago

@pspjuth Do you plan to make any additional changes in response to the review?

pspjuth commented 7 years ago

@chaorace I definitiely plan to look more at this, I've just been totally swamped by work. Vacation is coming up so that will help :-)

astog commented 7 years ago

@pspjuth Haha, I also finished my Naturalist Lens version 😄. I wanted to do it a lot earlier but other things got in the way and I had to take a break from modding. I'm curious about the types of tiles you created. What is the difference ok and raw park plots. Also what do you mean by fixable park plots? Is it that an improvement can be removed to make place for a National Park?

bollbas commented 7 years ago

@astog raw park plots in @pspjuth method are the plots that you count in your method. Ok park plots are the plots that are ready to become raw park plots after some "fixes" (adding neutral tiles to your territory or removing improvements for example). Fixable park plots are the plots that should be "fixed" to become ok park plots. If a diamond consists of 4 ok hexes they become raw park plots. Here is an example:

  1. pspjuth (when he will make additional changes in response to the review): more_lenses_1
  2. astog: more_lenses_2 And by the way your colors are a bit dark for me.
astog commented 7 years ago

That is a lot more useful than my version. As long as @pspjuth permits, I want to use his code for this lens.

pspjuth commented 7 years ago

Just a quick update: I will be able to take care of this mid next week.

@astog, feel free to use my code in MoreLenses if you want. I have some more mixed lens stuff at https://github.com/pspjuth/cqui/commits/mystuff if you want to have a look and use any of it.

astog commented 7 years ago

Update, I integrated this lens in my latest commit. @pspjuth thank you again for the original code. I added some more logic checks and a few fixes mentioned in the feedback above.

chaorace commented 7 years ago

@pspjuth I'm closing this PR now since the changes have since been absorbed into the full More Lenses mod. Rest assured, I'll remember to credit you in the usual places when the new ML version gets integrated into CQUI