search

CQUI-Org / cqui

Civilization 6 - Chao's Quick UI. Reduce clicks and manage your empire faster!
MIT License
318 stars 64 forks source link

Update production panel's data - fix, Update data when swap tiles - fix #566

Closed bollbas closed 7 years ago

bollbas commented 7 years ago

Removed unnecessary lines when swap tiles and when change city yield focus as soon as production panel updates now with Events.CityFocusChanged. Fixed CQUI_UpdateAllCitiesCitizens function to not to use incorrect variable that caused crash sometimes when try to quickload a game right after swap tiles. And also fixed OnTileImproved and RefreshOnTurnRoll functions to not to use incorrect variable. This PR is related to 562368fcba1991e6e64fcee78a0bfa1e24a1bb0d #527 #535 #558

chaorace commented 7 years ago

I'm sorry, the changelog for this PR is just absolutely gored. I need you to revise the history of this PR to make more sense and to either consolidate the whitespace mangling into a single commit or to remove it entirely. Right now it is difficult to review this PR when the diff view is like that

bollbas commented 7 years ago

Done. I also offer to completely remove RefreshOnTurnRoll function from citypanel.lua as soon as it triggers on every player's turn including city states and does nothing useful. It can be done in this PR. What do you think of it?

chaorace commented 7 years ago

@bolbass That function was introduced in 562368fcba1991e6e64fcee78a0bfa1e24a1bb0d. The useful thing it does is prevent desyncs in MP

bollbas commented 7 years ago

@chaorace, I'm sorry but I checked it and it was easy to review changes when using Hold shift + click to select a range option in Files changed >> Changes from all commits. I thought you are going to use it also.

chaorace commented 7 years ago

Everything's great! Thanks for contributing