CQuIC / qcircuit

A quantum circuit drawing application
GNU General Public License v2.0
168 stars 43 forks source link

Added commands #19

Closed symbiosdotwiki closed 9 years ago

symbiosdotwiki commented 9 years ago

\qwa and \cwa for arrow wires

\cds for inserting … indicating general circuit

\sgate for creating gates split over non-adjacent rows

\metersymb is a new meter aesthetic

\meterB allows for a measurement operator to be added

\smeterB allows for split meters over non-adjacent rows

\cctrl allows for classical control

\inputgroups for allowing multiple rows to represent one state

symbiosdotwiki commented 9 years ago

Let me know if examples are useful/necessary

i2000s commented 9 years ago

Thank you for contributing! Could you add in the new command demons in the Qtutorial.tex file? I think @Travis-S will take a closer look once this is done.

symbiosdotwiki commented 9 years ago

Should I add one new circuit per addition?

symbiosdotwiki commented 9 years ago

oh, I see how its setup -_-

i2000s commented 9 years ago

Generally if would be nice if you can add some examples on the related sections in the main text and also summarize the commands in the last appendix. People will see if the new commands are necessary or can be simplified. Thanks.

Travis-S commented 9 years ago

Seconding @i2000s' thoughts here.

There are three changes I would suggest before this PR should be accepted, all of them revolving around documenting the new commands in the Qtutorial.tex file. In particular:

If those changes are made and I am able to recompile the tutorial on my laptop, I think that would be a sufficient "test" to merit pulling in those changes.

Out of curiosity, what led you to require these new commands in your own work?

symbiosdotwiki commented 9 years ago

Adding documentation now

I needed these to do the homework from Kitaev's Ph135c course in 2013. Just thought I should add these when I saw there was now a GitHub repo

Travis-S commented 9 years ago

Cool! Glad qcircuit was helpful. As you can see, the project has gone a bit stale. I do wonder what people use these days for drawing quantum circuits...or maybe the field has simply moved away from doing so!

symbiosdotwiki commented 9 years ago

Yeah at the time there was basically only qcircuit, but it seemed like most people had modified it for personal use or crated their own tex library based on the circuits I was seeing.

Hopefully a public repo will help to standardize that slowly.

symbiosdotwiki commented 9 years ago

Let me know if the updated tutorial is ok, hopefully no typos

Travis-S commented 9 years ago

I will review this tonight (have to figure out how to do PR through the command line). Assuming the tutorial compiles and the new commands are documented reasonably well, I will merge.

Travis-S commented 9 years ago

This PR is closed, incorporating the changes proposed by @nwaxiomatic, with the addition of more documentation in the Qtutorial.tex file above those initially made.