search

CR6Community / CR-6-touchscreen

CR-6 SE touchscreen software extended with more functionality and pages than the stock CR-6 touchscreen software.
https://cr6community-support-team.gitbook.io/cr6comm-touchscreen-refactored-firmware-docs/
151 stars 34 forks source link

Add Tools directory and files to Feat/dwin nextgen support #68

Closed Thinkersbluff closed 2 years ago

Thinkersbluff commented 2 years ago

I forked this repository, to help me learn how to work with these tools on a local copy of my own, and as requested in the extui ReadMe.

UPDATE (27 April 2022): I started this PR started as a "practice-run", by proposing that the DGUS Tools and How-To info be updated on the extui branch.
It then continued to evolve, by accident (oops!), when I continued to push my other changes to the same branch on my repository, while I finished updating the work that InsanityAutomation had started. At this point, the changes bundled under this PR are ready to consider for a squash-merge back into the main extui branch, with the possible exception that the wonderfully detailed "How To DGUS" knowledge has not been retained and should not be lost.

I recommend that we capture and move that information into the WIKI as its own dedicated section, and that we continue to work on updating and improving it, to lower the barrier for future developers and maintainers of this UI firmware.

Sebazzz commented 2 years ago

LGTM so far!

Let's refine the README and flashing instructions a bit, remove the DRAFT files (so the repository size is less inflated - let's squash-commit-merge this so those files won't exist in the end result), and then I think we can offer these files as part of a 6.1b beta release.

Thinkersbluff commented 2 years ago

So this is part of what I mean when I say I am not very GitHub literate.

I did not realize that continuing to commit changes to the same branch on my fork would result in a continuing evolution of the PR.

I have removed the DRAFT folders.

I am now refining the README.MD file in the RC folder. Are there specific points you would like me to add/delete/modify?

Sebazzz commented 2 years ago

The most important thing to clarify is the DWIN OS upgrade.

As for the rest, check my remarks in the "files" tab.

Thinkersbluff commented 2 years ago

I believe this conflicting part of the PR has been overtaken by events. As long as the latest TFT files are kept in the merge, we will be ok ignoring these ones.

Sebazzz commented 2 years ago

I see what the problem with merging is. This PR wants to merge to the feature branch instead of extui, but we should merge to extui instead.

Sebazzz commented 2 years ago

Changed to extui.